]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
environment: Fix transition callback
authorFlorian Müllner <fmuellner@gnome.org>
Wed, 7 Aug 2019 00:26:32 +0000 (02:26 +0200)
committerFlorian Müllner <fmuellner@gnome.org>
Wed, 7 Aug 2019 00:40:13 +0000 (02:40 +0200)
This is rather embarrassing - we currently confuse the transition with
the finished parameter, which means we always run the onComplete handler
no matter whether the transition was interrupted or actually completed.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/668

js/ui/environment.js

index b00b74dd9546f2e13091d20bd09741443e0ae6af..a248ea069d496cbc6c9efb6c484f26daa23bef1e 100644 (file)
@@ -64,7 +64,7 @@ function _trackTransition(transition, callback) {
     if (_easingTransitions.has(transition))
         transition.disconnect(_easingTransitions.get(transition));
 
-    let id = transition.connect('stopped', isFinished => {
+    let id = transition.connect('stopped', (t, isFinished) => {
         _easingTransitions.delete(transition);
         callback(isFinished);
     });